Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 7: (7 comments) https://gerrit.ovirt.org/#/c/39945/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 558: } Line 559: } Line 560: Line 561: // If meta volume then set the CLI based snapshot scheduling flag accordingly Line 562: if (cluster.getGlusterCliBasedScheduling() > don't you have to override the gluster cli scheduling only if there's an en Yes, this has to set only a flag gluster side. Need to pass false for the VDS parameter's second argument. Later when user schedules a snapshot from UI, CLI based scheduling would be disabled. Line 563: && GlusterConstants.GLUSTER_META_VOLUME_NAME.equalsIgnoreCase(volume.getName())) { Line 564: VDSReturnValue retValue = Line 565: runVdsCommand(VDSCommandType.OverrideGlusterVolumeSnapshotSchedule, Line 566: new GlusterVolumeSnapshotSchedulingVDSParameters(getClusterUtils().getRandomUpServer(volume.getClusterId()) Line 563: > shouldn't there be a check if cluster supports the snapshot feature? done https://gerrit.ovirt.org/#/c/39945/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java: Line 45: private > You could move this to an internal command, as it is called from 2 places. Can try this Line 48: { > can avoid nesting by Done https://gerrit.ovirt.org/#/c/39945/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 259: public > rename to isGlusterCliBasedSchedulingOn ? Done https://gerrit.ovirt.org/#/c/39945/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java: Line 25: public > shouldn't this be configured in vdc_options? Done https://gerrit.ovirt.org/#/c/39945/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 1872: StatusOnlyReturnForXmlRpc > when will this be called? Its not called currently from engine. Just a wrapper for VDSM verb. May be we can remove and later on need basis get added. -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
