Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/39945/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java: Line 47: GlusterVolumeEntity metaVolume = Line 48: getGlusterVolumeDao().getByName(getVdsGroupId(), Line 49: Config.<String> getValue(ConfigValues.GlusterMetaVolumeName)); Line 50: VDSGroup cluster = getVdsGroup(); Line 51: if (metaVolume != null && cluster.isGlusterCliBasedSchedulingOn()) { > Above lines can be extracted to a separate method to avoid the repetition b Done Line 52: VdcReturnValueBase returnValue = Line 53: runInternalAction(VdcActionType.DisableGlusterCliSnapshotScheduleInternal, Line 54: new DisableGlusterCliSnapshotScheduleParameters(getGlusterVolumeId(), true)); Line 55: -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
