Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 6: (6 comments) https://gerrit.ovirt.org/#/c/39945/6/backend/manager/dependencies/.gitignore File backend/manager/dependencies/.gitignore: Line 1: /bin > Is this change required? By mistake commited. will remove this. https://gerrit.ovirt.org/#/c/39945/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 1868: } Line 1869: } Line 1870: Line 1871: @Override Line 1872: public StatusOnlyReturnForXmlRpc engineSnapshotSchedulingEnable() { > 'gluster' prefix? Done Line 1873: try { Line 1874: return new StatusOnlyReturnForXmlRpc(vdsServer.engineSnapshotSchedulingEnable()); Line 1875: } catch (UndeclaredThrowableException ute) { Line 1876: throw new XmlRpcRunTimeException(ute); Line 1877: } Line 1878: } Line 1879: Line 1880: @Override Line 1881: public StatusOnlyReturnForXmlRpc engineSnapshotSchedulingDisable() { > 'gluster' prefix? Done Line 1882: try { Line 1883: return new StatusOnlyReturnForXmlRpc(vdsServer.engineSnapshotSchedulingDisable()); Line 1884: } catch (UndeclaredThrowableException ute) { Line 1885: throw new XmlRpcRunTimeException(ute); https://gerrit.ovirt.org/#/c/39945/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 528: if (!result.getReturnValue().getCanDoAction()) { Line 529: for (String entry : result.getReturnValue().getCanDoActionMessages()) { Line 530: if (entry.contains("Gluster CLI based scheduling is enabled")) { ///$NON-NLS-1$ Line 531: snapshotModel.setDisableCliScheduleChkBoxVisible(true); Line 532: break; > We need to show the error to the user and ask him to select the disable but Do you mean to popup an error dialog and on click of OK ask him to select the checkbox for disabling the CLI based scheduling? Line 533: } Line 534: } Line 535: snapshotModel.stopProgress(); Line 536: } else { https://gerrit.ovirt.org/#/c/39945/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java: Line 30: private ListModel<EndDateOptions> endByOptions; Line 31: private EntityModel<Date> endDate; Line 32: private boolean generalTabVisible; Line 33: private boolean scheduleTabVisible; Line 34: private boolean disableCliScheduleChkBoxVisible; > Why do we need a separate field for controlling visibility? Will try that Line 35: private ListModel<String> timeZones; Line 36: private EntityModel<Date> startAt; Line 37: private EntityModel<Date> executionTime; Line 38: private ListModel<List<DayOfWeek>> daysOfWeek; https://gerrit.ovirt.org/#/c/39945/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java: Line 240: GlusterVolumeSnapshotModel model = (GlusterVolumeSnapshotModel) sender; Line 241: if ("disableCliScheduleChkBox".equals(args.propertyName)) { //$NON-NLS-1$ Line 242: disableCliScheduleEditor.setVisible(model.isDisableCliScheduleChkBoxVisible()); Line 243: } Line 244: } > This should be done in the presenter Done Line 245: }); Line 246: Line 247: updateVisibilities(object); Line 248: updateTabVisibilities(object); -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
