Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 11: (6 comments) https://gerrit.ovirt.org/#/c/39945/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 568: > Are we assuming that if oVirt is installed and managing the cluster, schedu It is told that if oVirt is installed and managing the cluster, oVirt only should be used for snapshot scheduling. Regarding multiple schedules per volume, we would require changes in feature. https://gerrit.ovirt.org/#/c/39945/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java: Line 25: > do this only if force ? Done https://gerrit.ovirt.org/#/c/39945/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/DisableGlusterCliSnapshotScheduleParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/DisableGlusterCliSnapshotScheduleParameters.java: Line 5: public > why not just use GlusterVolumeActionParameters? Done https://gerrit.ovirt.org/#/c/39945/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeSnapshotSchedulingVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeSnapshotSchedulingVDSParameters.java: Line 6: GlusterVolumeSnapshotSchedulingVDSParameters > similar - GlusterVolumeActionVDSParameters Done https://gerrit.ovirt.org/#/c/39945/11/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 902: GLUSTER_CLI_SNAPSHOT_SCHEDULE_DISABLED > append cluster to these messages? Done https://gerrit.ovirt.org/#/c/39945/11/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 1797: DefaultStringValue > will this warning be shown only if replica count is decreased ? This would be shown in general while removing any brick from the meta volume. -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
