Eli Mesika has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/39945/11/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 76: v_transparent_hugepages BOOLEAN , Line 77: v_migrate_on_error INTEGER, Line 78: v_virt_service BOOLEAN, Line 79: v_gluster_service BOOLEAN, Line 80: v_gluster_cli_based_snapshot_scheduled BOOLEAN, don't you need to refer to this column when the entity is inserted ? I saw that it is defaulted to TRUE , so my question is if you will not need to insert a new record with this column as FALSE ??? Line 81: v_tunnel_migration BOOLEAN, Line 82: v_emulated_machine VARCHAR(40), Line 83: v_detect_emulated_machine BOOLEAN, Line 84: v_trusted_service BOOLEAN, -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
