Martin Peřina has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/40152/7/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 53 Line 54 Line 55 Line 56 Line 57 > please merge this on conditional where: I cannot, <management-interfaces> are part of <management> and not part of <profile> Line 307: </thread-pool> Line 308: </thread-pools> Line 309: </subsystem> Line 310: #else Line 311: <subsystem xmlns="urn:jboss:domain:ejb3:2.0"> > does jboss-8 supports ejb3:2.0? We have to use 1.2 for EAP and 2.0 for WildFly (undertow module depends on 2.0 version). Line 312: <session-bean> Line 313: <stateful default-access-timeout="300000" cache-ref="simple" passivation-disabled-cache-ref="simple"/> Line 314: <singleton default-access-timeout="300000"/> Line 315: </session-bean> Line 365: </local-cache> Line 366: </cache-container> Line 367: </subsystem> Line 368: #else Line 369: <subsystem xmlns="urn:jboss:domain:infinispan:2.0"> > does jboss-8 supports ininispan:1.1? We have to use 1.1 for EAP and 2.0 for WildFly (using 1.1 on WildFly produces error about caching not initialized) Line 370: <cache-container name="web" default-cache="passivation" module="org.wildfly.clustering.web.infinispan"> Line 371: <local-cache name="passivation" batching="true"> Line 372: <file-store passivation="true" purge="false"/> Line 373: </local-cache> Line 600: <subsystem xmlns="urn:jboss:domain:io:1.1"> Line 601: <worker name="default"/> Line 602: <buffer-pool name="default"/> Line 603: </subsystem> Line 604: #end if > please move all complete subsystems that differ between the versions here, IMO it makes sense to have the same subsystem by themselves, because it will lower the chance to forgot update configuration also for the other type of supported AS. If we have two files (one per supported AS), then it's obvious that you should apply your change to both files. If you have everything in one file, then IMO is more obvious to have same subsystems by themselves. Line 605: </profile> Line 606: Line 607: <interfaces> Line 608: <interface name="loopback"> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
