Martin Peřina has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/40152/7/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 365: </local-cache> Line 366: </cache-container> Line 367: </subsystem> Line 368: #else Line 369: <subsystem xmlns="urn:jboss:domain:infinispan:2.0"> > just to make sure, all these settings are not part of subsystem defaults? This is the default as specified in standalone.xml in WildFly distribution. Line 370: <cache-container name="web" default-cache="passivation" module="org.wildfly.clustering.web.infinispan"> Line 371: <local-cache name="passivation" batching="true"> Line 372: <file-store passivation="true" purge="false"/> Line 373: </local-cache> Line 600: <subsystem xmlns="urn:jboss:domain:io:1.1"> Line 601: <worker name="default"/> Line 602: <buffer-pool name="default"/> Line 603: </subsystem> Line 604: #end if > if we have enough simple (non conditional) stuff, we can #include it based I don't understand. Do you want to split the file into "${PART}-${JBOSS_MAJOR}.xml.in" in all currently used "#if $JBOSS_MAJOR ..." and use #include for those parts? Line 605: </profile> Line 606: Line 607: <interfaces> Line 608: <interface name="loopback"> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
