Alon Bar-Lev has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/40152/7/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 365: </local-cache> Line 366: </cache-container> Line 367: </subsystem> Line 368: #else Line 369: <subsystem xmlns="urn:jboss:domain:infinispan:2.0"> > This is the default as specified in standalone.xml in WildFly distribution. in most cases the subsystem has defaults, and what in standalone.xml is only for reference of what you can change. Line 370: <cache-container name="web" default-cache="passivation" module="org.wildfly.clustering.web.infinispan"> Line 371: <local-cache name="passivation" batching="true"> Line 372: <file-store passivation="true" purge="false"/> Line 373: </local-cache> Line 600: <subsystem xmlns="urn:jboss:domain:io:1.1"> Line 601: <worker name="default"/> Line 602: <buffer-pool name="default"/> Line 603: </subsystem> Line 604: #end if > I don't understand. Do you want to split the file into "${PART}-${JBOSS_MAJ I would like to make this easier to read and maintain. if we have large chunk of text that is not customized, I think we can move it into a separate file, leaving only product customization in this file. probably this is valid only for subsystems as the other are trivial. it is unfortunate that jboss selected xml format for this file. anyway, this is just a suggestion. Line 605: </profile> Line 606: Line 607: <interfaces> Line 608: <interface name="loopback"> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
