Alon Bar-Lev has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40152/5/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 491: <expose-resolved-model/> Line 492: <expose-expression-model/> Line 493: <remoting-connector/> Line 494: </subsystem> Line 495: #end if > Well, I disagree. Engine code changes was interesting part. It's pain in th the entire practice was to minimize the changes between implementations of our application regardless of jboss, the exact opposite, this will drive higher chance of compatibility of application to different versions of jboss. you are doing this exactly the opposite. there is nothing new in my statement, I wrote it at my first message of task introduction. and I keep repeating this. first time you actually address this. I guess I am done, do whatever you like, you will maintain this anyway. as we saw even during this process, you do need help to simplify and reduce complexity or even use the technologies that are provided correctly. Line 496: Line 497: #if $JBOSS_MAJOR < 7 Line 498: <subsystem xmlns="urn:jboss:domain:jpa:1.0"> Line 499: <jpa default-datasource=""/> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
