Martin Peřina has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/40152/6/packaging/services/ovirt-engine/ovirt-engine.py File packaging/services/ovirt-engine/ovirt-engine.py: Line 50: def __init__(self): Line 51: super(Daemon, self).__init__() Line 52: self._tempDir = None Line 53: self._jbossRuntime = None Line 54: self._jbossVersion = {} > should be None if nothing Done Line 55: self._jbossConfigFile = None Line 56: self._defaults = os.path.abspath( Line 57: os.path.join( Line 58: os.path.dirname(sys.argv[0]), Line 246: self._jbossVersion['JBOSS_MAJOR'] = int(match.group('major')) Line 247: self._jbossVersion['JBOSS_MINOR'] = int(match.group('minor')) Line 248: self._jbossVersion['JBOSS_REVISION'] = int( Line 249: match.group('revision') Line 250: ) > . Done Line 251: break Line 252: Line 253: if self._jbossVersion.get('JBOSS_MAJOR') is None: Line 254: raise RuntimeError(_('Cannot detect JBoss version')) Line 247: self._jbossVersion['JBOSS_MINOR'] = int(match.group('minor')) Line 248: self._jbossVersion['JBOSS_REVISION'] = int( Line 249: match.group('revision') Line 250: ) Line 251: break > please use python correctly: Done Line 252: Line 253: if self._jbossVersion.get('JBOSS_MAJOR') is None: Line 254: raise RuntimeError(_('Cannot detect JBoss version')) Line 255: https://gerrit.ovirt.org/#/c/40152/6/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: > again, I am asking reformat patch to be a base of this patch so reviewers c Done Line 1: <?xml version='1.0' encoding='UTF-8'?> Line 2: Line 3: #if $JBOSS_MAJOR < 7 Line 4: <server xmlns="urn:jboss:domain:1.1"> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
