Martin Peřina has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/40152/5/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 491: <expose-resolved-model/> Line 492: <expose-expression-model/> Line 493: <remoting-connector/> Line 494: </subsystem> Line 495: #end if > ok, this is the interesting part, how to make this service the lowest commo Well, I disagree. Engine code changes was interesting part. It's pain in the ass to try minimize this file by doing smallest possible changes and test if nothing break in 4 different JBoss versions for each change :-( IMO we should use the default provided by each JBoss version and change it only when we have some issues with it. Line 496: Line 497: #if $JBOSS_MAJOR < 7 Line 498: <subsystem xmlns="urn:jboss:domain:jpa:1.0"> Line 499: <jpa default-datasource=""/> Line 741: port="$getinteger('ENGINE_HTTPS_PORT')" Line 742: #else Line 743: port="0" Line 744: #end if Line 745: /> > we have template replace so you can: Done Line 746: #end if Line 747: Line 748: <socket-binding name="txn-recovery-environment" port="8704"/> Line 749: <socket-binding name="txn-status-manager" port="8705"/> -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
