Allon Mureinik has posted comments on this change.

Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................


Patch Set 5: Fails

(1 inline comment)

Frankly, this looks like a considerably less elegant solution to me, but arcus 
senilis.

thanks for the catch as compensate() - lack of attention.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 317:      * </ul>
Line 318:      * </ol>
Line 319:      * <li>Remove all the snapshots for this command, since we 
handled them.</li> </ol>
Line 320:      */
Line 321:     protected void compensate() {
Leftover from previous patch, my bad.
thanks for the catch.
Line 322:         getCurrentTaskHandler().compensate();
Line 323:     }
Line 324: 
Line 325:     @SuppressWarnings({ "unchecked", "synthetic-access" })


--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to