Michael Kublin has posted comments on this change. Change subject: core: [WIP] introducing SPMAsyncTaskHandler ......................................................................
Patch Set 8: I would prefer that you didn't submit this There are a great many things wrong with circular references: 1. Circular class references create high coupling; both classes must be recompiled every time either of them is changed. 2.Circular assembly references prevent static linking, because B depends on A but A cannot be assembled until B is complete. 3.Circular object references can crash naïve recursive algorithms (such as serializers, visitors and pretty-printers) with stack overflows. The more advanced algorithms will have cycle detection and will merely fail with a more descriptive exception/error message. 4.Circular object references also make dependency injection impossible, significantly reducing the testability of your system. 5.Objects with a very large number of circular references are often God Objects. Even if they are not, they have a tendency to lead to Spaghetti Code. 6.Circular entity references (especially in databases, but also in domain models) prevent the use of non-nullability constraints, which may eventually lead to data corruption or at least inconsistency. 7.Circular references in general are simply confusing and drastically increase the cognitive load when attempting to understand how a program functions. -- To view, visit http://gerrit.ovirt.org/7956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
