Ayal Baron has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 844: boolean functionReturnValue = false;
Line 845: boolean exceptionOccurred = true;
Line 846: try {
Line 847: logRunningCommand();
Line 848: getCurrentTaskHandler().execute();
iiuc, what you'd really like to do is get rid of executeCommand altogether
(instead of pushing it into execute by default).
To do that and avoid the indirection (getCurrentTaskHandler().execute() calling
back into cmd.executeCommand) you could just have the logic that drives the
handlers here. The handler should be pure logic and the driver around it kept
out of it.
Line 849: functionReturnValue = getSucceeded();
Line 850: exceptionOccurred = false;
Line 851: } catch (RepositoryException e) {
Line 852: log.error(String.format("Command %1$s throw Database
exception", getClass().getName()), e);
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
