Allon Mureinik has posted comments on this change.

Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 142:             commandIdFromParameters = Guid.NewGuid();
Line 143:             getParameters().setCommandId(commandIdFromParameters);
Line 144:         }
Line 145: 
Line 146:         commandId = commandIdFromParameters;
Indeed, by design.
This is a stuby SPMTaskHandler used for backwards compatibility to delegate 
back to the actual methods in old Commands.
Line 147:         taskHandlers = initTaskHandlers();
Line 148:     }
Line 149: 
Line 150:     /**


--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to