Michael Kublin has posted comments on this change. Change subject: core: [WIP] introducing SPMAsyncTaskHandler ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 142: commandIdFromParameters = Guid.NewGuid(); Line 143: getParameters().setCommandId(commandIdFromParameters); Line 144: } Line 145: Line 146: commandId = commandIdFromParameters; So, it bad design, I don't see any reason for these. What is meaning of backwards compatibility for our internal code, we can change it as we want. Cyclic reference is anti-pattern. Line 147: taskHandlers = initTaskHandlers(); Line 148: } Line 149: Line 150: /** -- To view, visit http://gerrit.ovirt.org/7956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
