Michael Kublin has posted comments on this change. Change subject: core: [WIP] introducing SPMAsyncTaskHandler ......................................................................
Patch Set 3: I would prefer that you didn't submit this Sorry, but these is a very bad design. First of all, you increase a memory footprint of the system, additional object for every command. Second, why I need additional class which will replace all functionality of the base class what I will achieve. Third, by your implementation we have CommandBase class which points on SPMAsyncTaskHandler and SPMAsyncTaskHandler is points on the same CommandBase. You are building linked list? No, correct answer circular reference, these never can be good, in our case almost all object will have a circular references. -- To view, visit http://gerrit.ovirt.org/7956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
