Maor Lipchuk has posted comments on this change.
Change subject: core: Support undoing diskless previews
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 78: lockVmWithCompensationIfNeeded();
Fron patch set 3:
Allon: you don't want someone removing it (a VDSM command), while you're in the
middle of snapshoting, IMHO.
Answer: If the VM has no disks then the lock in the memory should be enough.
User will not be able to remove the VM.
You can use the freelock() after removing the snapshots from DB, then you can
simply remove the call to endActionOnVmConfiguration() by only call
UpdateVmInSpm(getVm().getstorage_pool_id(), Arrays.asList(getVm()));
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 259: if (getVm() != null) {
Not sure why we check if vm can be null here, it should be verified in the
canDoAction when executed, and if the VM has disks then the VM should not be
deleted, so I don't think vm can be null
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
