Allon Mureinik has posted comments on this change. Change subject: core: Support undoing diskless previews ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java Line 78: lockVmWithCompensationIfNeeded(); you don't want someone removing it (a VDSM command), while you're in the middle of snapshoting, IMHO. Line 108: EndVmCommand(); Done Line 191: // Currently UI sends the "in preview" snapshot to restore when "Commit" is pressed. new eclipse, new problems. will fix. -- To view, visit http://gerrit.ovirt.org/6676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
