Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 111: }
Original flow was broken IMHO:
1 - no tasks => failure. Fair enougth [although we're inrtentionally changing
it now]
2. Some tasks => success, but update the last fault regardless of whether it
was a success or not, either masking or not masking the a real failure
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 258: protected void endActionOnVmConfiguration() {
This is called at the end of an syncTask.
Before firing an asyncTask you should lock the VM in the database.
I think if this doesn't happen an NPE is the least of our concerns - but I get
your point - perhaps this isn't the best time to rock the baot.
I'll put it back since it really isn't a part of this patch, and we can handle
it later.
....................................................
Commit Message
Line 10: on disks.
Done
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
