Maor Lipchuk has posted comments on this change. Change subject: core: Support undoing diskless previews ......................................................................
Patch Set 3: I would prefer that you didn't submit this (3 inline comments) we should not use EndVmCommand, if we don't have disks. I think it's better to refactor the logic to do specifically treatment for VM without disks. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java Line 78: lockVmWithCompensationIfNeeded(); I'm not sure we need to lock the VM if he has no disks. Line 108: EndVmCommand(); we should not use EndVmCommand. here, this procedure is used for tasks. I think it's better to refactor the logic to do specifically treatment for VM without disks. Line 191: // Currently UI sends the "in preview" snapshot to restore when "Commit" is pressed. Are you sure your formatter is updated, I think the added spaces here are redundant. -- To view, visit http://gerrit.ovirt.org/6676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
