Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 92: if (getImagesList().size() > 0) {
Done
Line 99: return;
If there is no need for async tasks - we call EndCommand manually (the else
block)
If there are async tasks - the AsyncTaskManager will call EndCommand when
they're done.
if we were unable to to create the tasks even though they are needed - the task
returns with a fault - we should /not/ call endCommand.
Line 107: }
restoreSnapshotAndRemoveObsoleteSnapshots() restores the snapshot you want, and
flags the obsolete ones for removal.
removeSnapshotFromDB() actually does the removal.
removeSnapshot is not a method here - I don't know what you're refering to.
Line 108: else {
Not sure I understand the question.
success is initialized as false, and only set to true if the command succeeds.
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
