Alon Bar-Lev has posted comments on this change.

Change subject: core: Set artifact version to 3.3.4-SNAPSHOT
......................................................................


Patch Set 1:

in fedora we do create local pom, so whoever builds sdk rpms should use the 
local jars and poms, so it should behave correctly if has the right dependency 
of rpm.

at rhel we use brew which has -repolib subpackage to publish artifacts unless 
built by mead. If built by mead we use the latest tagged artifacts anyway.

I prefer build using direct release outputs on filesystem than fetching it the 
maven way from independent external source, if we are to use this integration 
better to create /usr/share/ovirt-engine/maven and publish a fully structured 
maven repo for the required artifacts that the sdk needs, and sdk will acquire 
artifacts from this local location and there is no reason to sync.

having wrote all the above, I cannot force how sdk should be build, and this 
change is not having any effect on engine apart of the maintenance, so sandro 
continue how you think best.

-- 
To view, visit http://gerrit.ovirt.org/23764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to