Juan Hernandez has posted comments on this change. Change subject: core: Set artifact version to 3.3.4-SNAPSHOT ......................................................................
Patch Set 1: The benefit is doing releases correctly. We have been neglecting this for a long time, but it isn't late to start doing it correctly. I don't believe that changing the POM files for each release is a huge task. In practical example, as I already explained, is the generation of the Python and Java SDKs. Currently we generate these from metadata extracted from a Live engine, which needs to be built and installed. This makes building and updating the SDKs cumbersome, and difficult to reproduce. The right way to do this is to generate this metadata as part of the build process of the engine, and include it in the generated artifacts, for example in restapi-definition-3.4.0. We can then make the build of the SDK depend on that artifact, and we should be able to trust that the metadata we extract from there won't be different the second time we regenerate the SDK. This isn't possible today because we keep overwriting the artifact files, with the same names and version numbers. -- To view, visit http://gerrit.ovirt.org/23764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
