Alon Bar-Lev has posted comments on this change. Change subject: core: Set artifact version to 3.3.4-SNAPSHOT ......................................................................
Patch Set 1: as far as I understand a binary release is only something that was built and signed one time at releng. you cannot re-compile a binary release, as there can be only one. The other problem of maven is that it must modify the sources and does not have pre-compile generation for poms. also, the *.pom can be modified before uploaded into artifactory, so that you do not need to build tag at all, and just fetch the certified artifacts from artifactory, no use of local repository for creating releases. the problem is within maven concepts as build system, but as I wrote previously, this is minor change for engine and accept noise within repo, it does not effect engine so no reason to keep arguing if it is only to be used by ovirt-engine-api. for other purposes, we should find a different way to split out the reusable components outside of the product/engine dependent version, and manage their releases in sync with packaging, even at the price of adding ./configure script for user to run before they open the ide. -- To view, visit http://gerrit.ovirt.org/23764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
