Juan Hernandez has posted comments on this change. Change subject: core: Set artifact version to 3.3.4-SNAPSHOT ......................................................................
Patch Set 1: So what version will be in my local maven repository when I do this? # git clone git://gerrit.ovirt.org/ovirt-engine # cd ovirt-engine # git checkout -b build ovirt-engine-3.3.4 # mvn clean install Will it generate 3.3.4 or 3.3.4-SNAPSHOT? If I checkout the release tag I should be building release artifacts, not snapshots. So in the commit associated to that release tag the pom.xml files shouldn't contain the -SNAPSHOT suffix. On the other hand in other commits, except the release ones, the pom.xml files should contain the -SNAPSHOT suffix. The right process, as I explained, is this: 1. Right before the release do a commit removing the -SNAPSHOT suffix. 2. Tag that commit with the release number. 3. Immediately do another commit increasing the version numbers and adding the -SNAPSHOT suffix. You can do that manually, with sed, or with any other tool, but the result should be committed into the repository. -- To view, visit http://gerrit.ovirt.org/23764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
