Juan Hernandez has posted comments on this change.
Change subject: core: Set artifact version to 3.3.4-SNAPSHOT
......................................................................
Patch Set 1:
The build of the engine from a tag can be trusted, but it needs additional
knowledge, because it just will overwrite an existing artifact in the local
repository, currently a -SNAPSHOT, as we don't remove this for releases either.
So in the POM of the SDK we have to add something like this:
<dependency>
<groupId>org.ovirt.engine.api</groupId>
<artifactId>interface</artifactId>
<version>3.3.0-SNAPSHOT</version>
</dependency>
This actually means "take the most recent 3.3.0-SNAPSHOT, hopefully it will
match the released engine, but it may not if you didn't use the right commit or
if you did another build after that one". The errors resulting from this are
only detecting when testing the generated and released SDKs.
What we should do instead is the following:
<dependency>
<groupId>org.ovirt.engine.api</groupId>
<artifactId>interface</artifactId>
<version>3.3.3</version>
</dependency>
In this case the person building the SDKs doesn't have to worry about the build
of the engine, because that artifact can have been generated only from the
right version of the engine, as there should be only one commit that contains
this version number. The artifact will either be missing or correct.
This is nicely solved if we do maven artifact releases correctly.
Ideally these artifacts should be uploaded to a public repository (maven
central, or our own maven repository) so that the person building the SDKs
doesn't even need to checkout/build the engine. Nothing prevents doing that now.
--
To view, visit http://gerrit.ovirt.org/23764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
