Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 159: 'later, based on generated configuration.\n' Line 160: ).format( Line 161: managers=', '.join(managers), Line 162: ), Line 163: ) I now did a test. Our current code, on fedora 19, will never (?) show two managers. Doing 'service firewalld start' stops and disables iptables, doing 'service iptables start' stops and disables firewalld. Since we check for their status, and not merely if they exist, we won't have both active, and so not show both. 3.2 only checked for existence, so it did show both. What do you think? Line 164: response = self.dialog.queryString( Line 165: name='OVESETUP_CONFIG_FIREWALL_MANAGER', Line 166: note=_( Line 167: 'Firewall manager to configure ' -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
