Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 4: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 930: summary=True, Line 931: description=_('Firewall manager'), Line 932: postinstallfile=False, Line 933: # Changed to False to allow users to keep their own changes Line 934: # on upgrades. Done Line 935: ) Line 936: def FIREWALL_MANAGER(self): Line 937: return 'OVESETUP_CONFIG/firewallManager' Line 938: .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/firewall_manager.py Line 46: osetupcons.Stages.NET_FIREWALL_MANAGER_AVAILABLE, Line 47: ), Line 48: ) Line 49: def _customization(self): Line 50: return Will now remove this file. Line 51: managers = [] Line 52: if self.services.exists('firewalld'): Line 53: managers.append('firewalld') Line 54: if self.services.exists('iptables'): -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches