Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 4: Verified+1 Verified the following: 1. Upgrade from 3.2 - now does ask about firewall manager, also asks about websocket-proxy, if user chooses 'iptables' and 'yes' iptables is updated as expected 2. Further "upgrade" (with no code changes) - user is asked about firewall manager and if "no", iptables is not touched 3. Another "upgrade", this time with a configuration file in /etc/ovirt-engine-setup.conf.d having: OVESETUP_CONFIG/firewallManager=str:disabled User is not asked, iptables is not touched. Note that any value other than "str:iptables" and "str:firewalld" will work - we might want to limit that a bit. Or might not. Also note that having there 'none:None', which is what is saved in the generated answer file if user replies "no", will make a next run ask again. -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
