Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 159: 'later, based on generated configuration.\n' Line 160: ).format( Line 161: managers=', '.join(managers), Line 162: ), Line 163: ) Yes, but do you think we should have two questions? And if yes, which ones, and which of them to keep in the postinstall file? One day, we'll support other distros, and things will be more complex. E.g. in Debian there are many more "firewall managers" in the main repo, and IIRC they do not require exclusivity, and IIRC I even saw that under some circumstances some of them can cooperate. But for now, with only el6 (iptables or nothing) and fedora (firewalld xor iptables xor nothing, bugs notwithstanding), I think one question is enough. As they say, when we come to the bridge, we'll jump from it... Also, currently if both are stopped, we do not ask and do nothing. If we decide to change that, I think it should be done in 3.4. Line 164: response = self.dialog.queryString( Line 165: name='OVESETUP_CONFIG_FIREWALL_MANAGER', Line 166: note=_( Line 167: 'Firewall manager to configure ' -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
