Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 159: 'later, based on generated configuration.\n' Line 160: ).format( Line 161: managers=', '.join(managers), Line 162: ), Line 163: ) I think that having 2 questions may have sense on second execution. If we're running setup for the first time user choosing to configure the firewall should expect to have the firewall configured. On second execution, user may have decided to change firewall manager, or just need to run setup for clear zombie tasks, or just add an additional component or something else and may or may not want to change the firewall configuration automatically. Line 164: response = self.dialog.queryString( Line 165: name='OVESETUP_CONFIG_FIREWALL_MANAGER', Line 166: note=_( Line 167: 'Firewall manager to configure ' -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
