Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 5: (1 comment) > I even thought about showing some status about each of them: > enabled/disabled, active/inactive etc. maybe that is good information. .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 159: 'later, based on generated configuration.\n' Line 160: ).format( Line 161: managers=', '.join(managers), Line 162: ), Line 163: ) I feel like two question are in order, one question to select the firewall manager and not present it if only one is detected or auto selected, this can be saved in answer file. And the other if you want to apply the setting now. Or... maybe the other way around... first ask if you want to apply firewall setting, then if selected yes to ask about manager etc... Line 164: response = self.dialog.queryString( Line 165: name='OVESETUP_CONFIG_FIREWALL_MANAGER', Line 166: note=_( Line 167: 'Firewall manager to configure ' -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
