Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: use json for documentation mapping files
......................................................................
Patch Set 3:
(4 comments)
Also, I suggest adding README.manual similar to branding.
....................................................
File
backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java
Line 1: package org.ovirt.engine.docs.utils.servlet;
all this code to save 2 http gets, from my point of view it is insane.
Line 2:
Line 3: import java.io.BufferedReader;
Line 4: import java.io.File;
Line 5: import java.io.FileInputStream;
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
Line 152: return clientAgentType.version;
Line 153: }
Line 154:
Line 155: protected void fetchDocumentationFile() {
Line 156: fetchFile(getDocumentationBaseURL() + "userportal",
documentationFileFetchedEvent); //$NON-NLS-1$
please reuse branding application name constant.
Line 157: }
Line 158:
....................................................
File packaging/manual/docsconfig.properties
no need, if file is missing - as if empty.
if key not found as if key contains empty.
Line 1: # comma-separated list of json files that contain documentation
mappings for webadmin and userportal
Line 2: # example: webadmin=common.json,webadmin.json
Line 3: webadmin=
Line 4: userportal=
Line 1: # comma-separated list of json files that contain documentation
mappings for webadmin and userportal
Line 2: # example: webadmin=common.json,webadmin.json
Line 3: webadmin=
Line 4: userportal=
if this is config file now then add prefix so we can use other variables as
well.
for example:
index.xxx
--
To view, visit http://gerrit.ovirt.org/21392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
