Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: use json for documentation mapping files
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
Line 152: return clientAgentType.version;
Line 153: }
Line 154:
Line 155: protected void fetchDocumentationFile() {
Line 156: fetchFile(getDocumentationBaseURL() + "userportal",
documentationFileFetchedEvent); //$NON-NLS-1$
alexander, you have this value at client side as well no? if no, what is the
problem of passing this when the gwt servlet is activated just like the context
path?
Line 157: }
Line 158:
....................................................
File packaging/manual/docsconfig.properties
Line 1: # comma-separated list of json files that contain documentation
mappings for webadmin and userportal
Line 2: # example: webadmin=common.json,webadmin.json
Line 3: webadmin=
Line 4: userportal=
if it is config file you should be able to add new values into it in future.
so add a prefix to distinguish various of usages so there will be no conflict.
--
To view, visit http://gerrit.ovirt.org/21392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
