Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: use json for documentation mapping files
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
Line 152: return clientAgentType.version;
Line 153: }
Line 154:
Line 155: protected void fetchDocumentationFile() {
Line 156: fetchFile(getDocumentationBaseURL() + "userportal",
documentationFileFetchedEvent); //$NON-NLS-1$
if there is use of the same component at client side within multiple
applications, it should be able to easily know where it is located and what to
open.
this is part of the interface between docs and application, and I think that
the entire application should share the *SAME* application name to interact
with all external components. I do not see any value in hard code this multiple
times within implementation.
it is not by mistake that you have the same string for both usages.
Line 157: }
Line 158:
....................................................
File packaging/manual/docsconfig.properties
Line 1: # comma-separated list of json files that contain documentation
mappings for webadmin and userportal
Line 2: # example: webadmin=common.json,webadmin.json
Line 3: webadmin=
Line 4: userportal=
yes.
--
To view, visit http://gerrit.ovirt.org/21392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
