Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: use json for documentation mapping files ......................................................................
Patch Set 2: > and regardless you should go via the index so specify '.json' is incorrect. why? > that work the complexity of adding a servlet? the multiple file logic needs to live somewhere -- either on the server or the GWT client. I felt it was easier to have that logic be server side. You're right, the requests aren't a huge deal, but they add up -- and the spirit of GWT is to eliminate as many requests as possible. I'm comfortable with the servlet. -- To view, visit http://gerrit.ovirt.org/21392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
