Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: use json for documentation mapping files ......................................................................
Patch Set 2: (3 comments) please use the branding application name or share that name in some other term. please do not use direct file but either: 1. register servlet with name space: /index/* and access /refs/@application_name@ 2. register servlet with query string, and access based on: index?application=@application_name@ and regardless you should go via the index so specify '.json' is incorrect. --- maybe I do not understand... you are trying to save *TWO*(?!?) one time extra requests to server (in the case of we have common and webadmin tables pointed by index). that work the complexity of adding a servlet? I do not think it is. .................................................... File packaging/manual/common.json you do not need empty file as file is not being accessed directly. .................................................... File packaging/manual/docsconfig.properties you do not need this file file as file is not being accessed directly. Line 1: # lists of json files that contain documentation mappings for webadmin and userportal Line 2: webadmin=common.json,webadmin.json Line 3: userportal=common.json,userportal.json .................................................... File packaging/manual/userportal.json you do not need this file file as file is not being accessed directly. -- To view, visit http://gerrit.ovirt.org/21392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
