Greg Sheremeta has posted comments on this change.

Change subject: userportal, webadmin: use json for documentation mapping files
......................................................................


Patch Set 3:

(1 comment)

All concerns addressed except for not hardcoding "webadmin" and "userportal"

Not sure what to do with those and I just don't understand the value GWT-side.

....................................................
File packaging/manual/docsconfig.properties
Line 1: # comma-separated list of json files that contain documentation 
mappings for webadmin and userportal
Line 2: # example: webadmin=common.json,webadmin.json
Line 3: webadmin=
Line 4: userportal=
Done


-- 
To view, visit http://gerrit.ovirt.org/21392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to