Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 4: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/misc.py Line 78: stage=plugin.Stages.STAGE_SETUP, Line 79: priority=plugin.Stages.PRIORITY_LOW, Line 80: ) Line 81: def _setup(self): Line 82: if self.environment[osetupcons.DBEnv.NEW_DATABASE]: this can be moved to condition of event, no? Line 83: self.logger.debug( Line 84: 'Forcing ACTION to SETUP because we are ' Line 85: 'creating a new database' Line 86: ) -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
