Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
Patch Set 5:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 80: self._parent = parent
Line 81: self._backup = None
Line 82: self.environment[
Line 83: osetupcons.RPMDistroEnv.VERSIONLOCK_MODIFIED
Line 84: ] = None
I think 3 state boolean should be used only when absolutely required. in this
case there is nothing wrong to assume X and then revert to Y.
Line 85:
Line 86: def __str__(self):
Line 87: return _("Version Lock Transaction")
Line 88:
--
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
