Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 2: Verified+1 (1 comment) Verified only setup after partial cleanup. I hope you'll like this one better. Note my comment about InterfaceError. I am not certain that other exceptions can't occur in similar circumstances, this one definitely happened to me. Still, we might want to be extra careful and ask the user about this. I checked some example scenario, decided that it's not related to this change, and opened another BZ https://bugzilla.redhat.com/1014012 . .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 87: if dbovirtutils.isNewDatabase(): Line 88: raise RuntimeError( Line 89: _('Unexpected empty database during upgrade') Line 90: ) Line 91: except (psycopg2.InterfaceError, RuntimeError) as e: Perhaps it's better to add 'except InterfaceError' to tryDatabaseConnect, not sure. Line 92: self.logger.debug( Line 93: 'Database connection failed while trying to upgrade from ' Line 94: 'legacy, creating a new database', Line 95: exc_info=True, -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
