Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
Patch Set 3:
(3 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
Line 23: import gettext
Line 24: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup')
Line 25:
Line 26:
Line 27: import psycopg2
no need
Line 28:
Line 29:
Line 30: from otopi import util
Line 31: from otopi import plugin
Line 87: raise RuntimeError(
Line 88: _('Unexpected empty database during upgrade')
Line 89: )
Line 90: self.environment[osetupcons.DBEnv.NEW_DATABASE] = False
Line 91: except Exception as e:
you do not need as e
Line 92: self.logger.debug(
Line 93: (
Line 94: 'Database connection failed while trying to
upgrade from '
Line 95: 'legacy, creating a new database',
Line 91: except Exception as e:
Line 92: self.logger.debug(
Line 93: (
Line 94: 'Database connection failed while trying to
upgrade from '
Line 95: 'legacy, creating a new database',
no need for 'creating a new...' here
Line 96: ),
Line 97: exc_info=True,
Line 98: )
Line 99:
--
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
