Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: partial cleanup - db only
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

Looks good to me but I would like that also someone else take a look at the 
code before approving.

....................................................
Commit Message
Line 11: the system as being legacy 3.2 and tried to upgrade, which failed.
Line 12: 
Line 13: This change makes the identification of upgrade from 3.2 legacy
Line 14: more strict and in such a situation setup-engine will continue as
Line 15: a new setup.
Well, I suppose this won't work with old 3.3 nightly installed with legacy 
setup. But I don't think we should keep support for that.
Line 16: 
Line 17: Bug-Url: https://bugzilla.redhat.com/987939
Line 18: Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6


-- 
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to