Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 1: (4 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 81: try: Line 82: dbovirtutils = database.OvirtUtils(plugin=self) Line 83: dbovirtutils.tryDatabaseConnect(environment=environment) Line 84: if dbovirtutils.isNewDatabase(): Line 85: raise raise what? Line 86: except: Line 87: self.logger.debug( Line 88: 'Database connection failed while trying to upgrade from ' Line 89: 'legacy, continuing as a new setup' Line 82: dbovirtutils = database.OvirtUtils(plugin=self) Line 83: dbovirtutils.tryDatabaseConnect(environment=environment) Line 84: if dbovirtutils.isNewDatabase(): Line 85: raise Line 86: except: except what? Line 87: self.logger.debug( Line 88: 'Database connection failed while trying to upgrade from ' Line 89: 'legacy, continuing as a new setup' Line 90: ) Line 86: except: Line 87: self.logger.debug( Line 88: 'Database connection failed while trying to upgrade from ' Line 89: 'legacy, continuing as a new setup' Line 90: ) please do not swallow exception, print exc_info to debug. Line 91: self.environment[osetupcons.CoreEnv.UPGRADE_FROM_LEGACY] = False Line 92: self.environment[ Line 93: osetupcons.CoreEnv.ACTION Line 94: ] = osetupcons.Const.ACTION_SETUP Line 90: ) Line 91: self.environment[osetupcons.CoreEnv.UPGRADE_FROM_LEGACY] = False Line 92: self.environment[ Line 93: osetupcons.CoreEnv.ACTION Line 94: ] = osetupcons.Const.ACTION_SETUP not sure this is the place to set it. consider to integrate this within core/misc.py, adding setup phase and reset upgrade if not legacy or something similar. Line 95: Line 96: -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
