suddendust commented on PR #14348:
URL: https://github.com/apache/pinot/pull/14348#issuecomment-2517134978
@Jackie-Jiang @soumitra-st Just a note: Till now, the metric
`DEDUP_PRIMARY_KEYS_COUNT` comes up (incorrectly) as:
`pinot_server_${partitionId}_Value{database="dedupPrimaryKeysCount",
// table="dedupPrimaryKeysCount.myTable",tableType="REALTIME",}`. I
have removed the regex that does it and now it is exported with the right name
and labels. The reason is that there is a dynamic `partitionId` in the metric
name, so I don't think anyone would've used this metric in either any dashboard
or an alert.
Ref:
```
if (serverGauge == ServerGauge.DEDUP_PRIMARY_KEYS_COUNT) {
//this gauge is currently exported as:
`pinot_server_${partitionId}_Value{database="dedupPrimaryKeysCount",
// table="dedupPrimaryKeysCount.myTable",tableType="REALTIME",}`. We
add an explicit test for it to maintain
// backward compatibility. todo:
ServerGauge.DEDUP_PRIMARY_KEYS_COUNT should be moved to
// gaugesThatAcceptPartition. It should be exported as:
// `pinot_server_dedupPrimaryKeysCount_Value{partition="3",
table="myTable",tableType="REALTIME",}`
addPartitionGaugeWithLabels(serverGauge, TABLE_NAME_WITH_TYPE);
assertGaugeExportedCorrectly(String.valueOf(3),
List.of(ExportedLabelKeys.DATABASE, serverGauge.getGaugeName(),
ExportedLabelKeys.TABLE,
"dedupPrimaryKeysCount.myTable",
ExportedLabelKeys.TABLETYPE, ExportedLabelValues.TABLETYPE_REALTIME),
EXPORTED_METRIC_PREFIX);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
