soumitra-st commented on code in PR #14348:
URL: https://github.com/apache/pinot/pull/14348#discussion_r1866307806
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -2,151 +2,20 @@ rules:
- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.controller(\\w+)\"><>(\\w+)"
name: "pinot_controller_$1_$2"
cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.helix\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_helix_$1_$2"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.helixZookeeperReconnects\"><>(\\w+)"
- name: "pinot_controller_helix_ZookeeperReconnects_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.idealstateZnodeSize\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_idealstateZnodeSize_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.idealstateZnodeByteSize\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_idealstateZnodeByteSize_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.replicationFromConfig\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_replicationFromConfig_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.numberOfReplicas\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_numberOfReplicas_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.percentOfReplicas\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_percentOfReplicas_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.percentSegmentsAvailable\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_percentSegmentsAvailable_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.segmentCount\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_segmentCount_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.segmentsInErrorState\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\"><>(\\w+)"
- name: "pinot_controller_segmentsInErrorState_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.dataDir\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_dataDir_$1_$2"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.numberSegmentUploadTimeoutExceeded\"><>(\\w+)"
- name: "pinot_controller_numberSegmentUploadTimeoutExceeded_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.numberTimesScheduleTasksCalled\"><>(\\w+)"
- name: "pinot_controller_numberTimesScheduleTasksCalled_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.periodicTaskNumTablesProcessed\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_periodicTaskNumTablesProcessed_$1_$2"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.pinotControllerLeader\"><>(\\w+)"
- name: "pinot_controller_pinotControllerLeader_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.pinotControllerPartitionLeader\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_partitionLeader_$1_$2"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.realtimeTableCount\"><>(\\w+)"
- name: "pinot_controller_realtimeTableCount_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.offlineTableCount\"><>(\\w+)"
- name: "pinot_controller_offlineTableCount_$1"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.tierBackendTableCount\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_tierBackendTableCount_$1_$2"
- cache: true
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ValidationMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_validateion_$4_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.cronSchedulerJobScheduled\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\"><>(\\w+)"
name: "pinot_controller_cronSchedulerJobScheduled_$5"
cache: true
labels:
database: "$2"
table: "$1$3"
taskType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\\.cronSchedulerJobTriggered\"><>(\\w+)"
- name: "pinot_controller_cronSchedulerJobTriggered_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- taskType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\\.cronSchedulerJobSkipped\"><>(\\w+)"
- name: "pinot_controller_cronSchedulerJobSkipped_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- taskType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\\.cronSchedulerJobExecutionTimeMs\"><>(\\w+)"
- name: "pinot_controller_cronSchedulerJobExecutionTimeMs_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- taskType: "$4"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\\.tableRebalanceExecutionTimeMs\"><>(\\w+)"
- name: "pinot_controller_tableRebalanceExecutionTimeMs_$5"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- result: "$4"
- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.taskStatus\\.([^.]*)\\.(\\w+)\"><>(\\w+)"
name: "pinot_controller_taskStatus_$3"
cache: true
labels:
taskType: "$1"
status: "$2"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.timeMsSinceLastMinionTaskMetadataUpdate\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.(\\w+)\"><>(\\w+)"
- name: "pinot_controller_timeMsSinceLastMinionTaskMetadataUpdate_$6"
- cache: true
- labels:
- database: "$2"
- table: "$1$3"
- tableType: "$4"
- taskType: "$5"
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(numMinionSubtasksRunning|numMinionSubtasksWaiting|numMinionSubtasksError|percentMinionSubtasksInQueue|percentMinionSubtasksInError)\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.(\\w+)\"><>(\\w+)"
+- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(timeMsSinceLastSuccessfulMinionTaskGeneration|lastMinionTaskGenerationEncountersError|timeMsSinceLastMinionTaskMetadataUpdate|numMinionSubtasksRunning|numMinionSubtasksWaiting|numMinionSubtasksError|percentMinionSubtasksInQueue|percentMinionSubtasksInError)\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.(\\w+)\"><>(\\w+)"
Review Comment:
Is there a way to not add the metric names (a|b|c) in the pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
