suddendust commented on PR #14348: URL: https://github.com/apache/pinot/pull/14348#issuecomment-2516425651
@soumitra-st >Did you validate this change (number and name of metrics) using the unit tests and running on an actual cluster? These have been validated using the unit tests. It'll be very hard, if not impossible, to validate that each of the metric is being exported with the correct names and labels on an actual cluster, as we cannot export all metrics at once (as we cannot execute all the code paths on which these metrics lie on an actual cluster). >Did you find any JMX metric that were not exported to Prometheus? No, all metrics are being exported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
