suddendust commented on PR #14348: URL: https://github.com/apache/pinot/pull/14348#issuecomment-2516420700
>Were you able to run a performance test to see if there were any resource savings after this change? I measured the memory being used by `java.util.regex.Pattern` objects before and after, there's a ~ 33% reduction: Before: <img width="634" alt="Screenshot 2024-12-04 at 1 09 19 PM" src="https://github.com/user-attachments/assets/6846811c-32e4-4988-9319-fe9b05859ab0";> Total: 64.82K After: <img width="631" alt="Screenshot 2024-12-04 at 1 09 31 PM" src="https://github.com/user-attachments/assets/aabc583f-bbe3-4240-80f1-25e031fb2c40";> Total: 43.32K However, I doubt there's be any significant impact on the container's memory usage considering how little memory these compiled regexps occupy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
