suddendust commented on code in PR #14348: URL: https://github.com/apache/pinot/pull/14348#discussion_r1861768993
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ########## @@ -1,206 +1,13 @@ rules: -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.authorization\"><>(\\w+)" - name: "pinot_broker_authorization_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.documentsScanned\"><>(\\w+)" - name: "pinot_broker_documentsScanned_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.entriesScannedInFilter\"><>(\\w+)" - name: "pinot_broker_entriesScannedInFilter_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.entriesScannedPostFilter\"><>(\\w+)" - name: "pinot_broker_entriesScannedPostFilter_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.freshnessLagMs\"><>(\\w+)" - name: "pinot_broker_freshnessLagMs_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.queries\"><>(\\w+)" - name: "pinot_broker_queries_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.queryExecution\"><>(\\w+)" - name: "pinot_broker_queryExecution_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.queryRouting\"><>(\\w+)" - name: "pinot_broker_queryRouting_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.reduce\"><>(\\w+)" - name: "pinot_broker_reduce_$4" - cache: true - labels: - database: "$2" - table: "$1$3" -- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^.]+)\\.)?([^.]*)\\.requestCompilation\"><>(\\w+)" - name: "pinot_broker_requestCompilation_$4" - cache: true - labels: - database: "$2" - table: "$1$3" - pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.requestSize\\.(([^.]+)\\.)?([^.]*)\"><>(\\w+)" Review Comment: The mbean for `requestSize` is created as: `pinot.broker.requestSize.myTable` For others, like `freshnessLag`, it is created as: `pinot.broker.myTable.freshnessLagMs` That's why the pattern is different. >Do we every match this rule? I assume you're asking if we ever match this rule. Yes, we do. If we remove this pattern, `requestSize` metric breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
